Re: CVS commit: src/sys/modules

[Christos Zoulas <christos%zoulas.com@localhost>]

Thanks!

christos

> On Feb 20, 2019, at 8:38 AM, Rin Okuyama <rokuyama.rk%gmail.com@localhost> wrote:
> 
>> On 2019/02/20 21:45, Christos Zoulas wrote:
>> In article <20190220051132.53C81FB17%cvs.NetBSD.org@localhost>,
>> Rin Okuyama <source-changes-d%NetBSD.org@localhost> wrote:
> ...
>>> Log Message:
>>> WARNS=3 for compat_netbsd32_* in order to appease sign-compare warnings
>>> for mips64, where NETBSD32_POINTER_TYPE is signed.
>> Let's limit it to mips64 then?
>> christos
> 
> Oops, sorry for ambiguous commit log. It is limited to mips64, e.g.,
> 
> Index: src/sys/modules/compat_netbsd32_09/Makefile
> diff -u src/sys/modules/compat_netbsd32_09/Makefile:1.2 src/sys/modules/compat_netbsd32_09/Makefile:1.3
> --- src/sys/modules/compat_netbsd32_09/Makefile:1.2    Sun Jan 27 02:08:45 2019
> +++ src/sys/modules/compat_netbsd32_09/Makefile    Wed Feb 20 05:11:30 2019
> @@ -1,4 +1,4 @@
> -#    $NetBSD: Makefile,v 1.2 2019/01/27 02:08:45 pgoyette Exp $
> +#    $NetBSD: Makefile,v 1.3 2019/02/20 05:11:30 rin Exp $
> .include "../Makefile.inc"
> @@ -14,4 +14,8 @@ CPPFLAGS+=    -I${NETBSDSRCDIR}/sys/externa
> SRCS+=    netbsd32_compat_09.c
> +.if !empty(MACHINE_ARCH:Mmips64*)
> +WARNS=    3
> +.endif
> +
> .include <bsd.kmodule.mk>