Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix

[Jason Thorpe <thorpej%me.com@localhost>]

Thanks!  This has been bothering me for a while, but I hadn’t had a chance to look at it.

-- thorpej
Sent from my iPhone.

> On Nov 19, 2018, at 8:14 AM, Christos Zoulas <christos%netbsd.org@localhost> wrote:
> 
> Module Name:    src
> Committed By:    christos
> Date:        Mon Nov 19 08:14:28 UTC 2018
> 
> Modified Files:
>    src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c
> 
> Log Message:
> It is not an error if we did not find any IPv4 interfaces. It could
> be the case we never have V4 interfaces (in a V6 system) so this
> is bogus. The code was recently changed to ignore loopback interfaces.
> If mdnsd was started too early, this means that no interfaces would
> be found (since interfaces down, with no addresses, or tentative
> are ignored). I put back the loopback interfaces yesterday to avoid
> this error, but this seems like the left hand not knowing what the
> right hand does because whoever removed the loopback interfaces
> from the list, did not read the 'self discovery' comment and the
> special code that deals with loopback in this file. Nevertheless,
> I think it is better to ignore the loopback interfaces in the long
> run, but it is ok to keep them around since the code is handling
> them just fine (and works both with and without them).
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.15 -r1.16 \
>    src/external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>