Re: CVS commit: src/sys/kern

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Oct 02, 2018 at 03:40:48AM +0200, Emmanuel Dreyfus wrote:
> Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:
> 
> > In any case, adding a workaround for a specific setup which can potentially
> > cause spurious failures for everyone is not appropriate.
> 
> I agree with that, but it is the case here?
> 
> Running with vnd backends on the root partition is not what I would call
> a specific setup,

You're the only one seeing this problem AFAIK

> and it is not obvious the change can do actual harm. 

Returning EAGAIN without reason is harmfull.

> 
> I agree a EAGAIN on unmount(2) as shutdown time would be a problem, but
> can it happen? /etc/rc.d/mountall calls umount -a after all processes

It's not called from reboot(2)

> using the filesystem have exit. What process would call fstrans_start()
> while umount tries to do a file suspension?

What about removable devices ? what about snapshots ?

And I may have missed other cases ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--