Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/mips/mips



On Wed, 8 Aug 2018, Martin Husemann wrote:

On Wed, Aug 08, 2018 at 12:11:39PM +0000, maya%netbsd.org@localhost wrote:
On Wed, Aug 08, 2018 at 01:59:46PM +0200, Martin Husemann wrote:
On Wed, Aug 08, 2018 at 11:49:21AM +0000, maya%netbsd.org@localhost wrote:
Can we use aprint_debug instead?

It is not even usefull for general debugging IMHO.

Martin

I like the idea of removing the messages entirely. The code was hard to
read when I had to do it, and I didn't find those messages helpful.

I meant: I like the way Simon changed it - it will not show up unless
you are explicitly debugging exec stuff.

Well, it could remain conditional, and in addition use aprint_debug() instead of printf(). So even if you've compiled it in, you don't see anything unless you also boot with debug (ie, boot -x).



+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+


Home | Main Index | Thread Index | Old Index