Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/dev



> Modified Files:
> 	src/sys/dev: audio.c
> 
> Log Message:
> Expose the audio_info structure of vchan zero(0) the mix ring to allow
> setting the hardware gain and balance via audioctl(1) using the -p 0
> switch.
> 
> It is not possible to influence the hardware gain/blance from the
> audio_info structure of vchans 1 onwards.  It is now possible to return
> the audio mixers audio format from the audio_info structure of vchan 0 to
> ease applications configuring for mmapped play back.
> 
> This is conformant to the audio specification posted on tech-kern see:
> 	"NetBSD Audio Specification 2018"
> or audio.7 manual page to be added in a follow up commit.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.453 -r1.454 src/sys/dev/audio.c

!       if (SPECIFIED(r->gain)) {
!               if (!sc->sc_usemixer || vc == &sc->sc_mixring) {
!                       au_get_gain(sc, &sc->sc_outports, &gain, &balance);
!                       error = au_set_gain(sc, &sc->sc_outports, r->gain, balance);

i think this should be sc_inports.

i wonder if the check of vc vs mixring should be put in an macro
or function.

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index