Re: CVS commit: src/external/bsd/ipf/dist/ipsend

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 29/04/2018 à 17:59, Christos Zoulas a écrit :
> Module Name:	src
> Committed By:	christos
> Date:		Sun Apr 29 15:59:07 UTC 2018
>
> Modified Files:
> 	src/external/bsd/ipf/dist/ipsend: ipsend.h
>
> Log Message:
> fix the build: tcpiphdr is now defined in tcp_var.h and tcp_var.h needs
> tcp_timer.h. This struct move is more trouble than its worth. It breaks
> header compatibility with other BSD's and can't be really removed because
> it is an installed header that will break other 3rd party software. I
> suggest that it gets reverted!

Not really. OpenBSD moved the definition to tcp_debug.h, and it doesn't look
like it caused them any trouble.

tcpiphdr and the like are not particularly documented, and are not supposed
to be used by userland.

That ipsend relies on it is more an ipsend bug than anything else I think, if
it wants such a structure nothing prevents it from defining it.

By the way there's already a tcpiphdr redefinition in bin/ipsend/tcpip.h,
not sure what it means, but whatever.