Re: IP6_EXTHDR_GET

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 09/02/2018 à 00:42, maya%netbsd.org@localhost a écrit :
> On Thu, Feb 08, 2018 at 08:06:21PM +0000, Maxime Villard wrote:
> >   		af = AF_INET;
> >   		iphlen = sizeof(struct ip);
> > -		IP6_EXTHDR_GET(th, struct tcphdr *, m, toff,
> > -		    sizeof(struct tcphdr));
> > -		if (th == NULL) {
> > -			TCP_STATINC(TCP_STAT_RCVSHORT);
> > -			return;
>
> is IP6_EXTHDR_GET misnamed or is it incorrect for use with non-INET6?

there is ip6 in the name but it performs a basic mbuf operation, it's not
incorrect to use it in ip4, so yes, a bit misnamed