Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/net



    Date:        Wed, 22 Nov 2017 04:56:52 +0000
    From:        "SAITOH Masanobu" <msaitoh%netbsd.org@localhost>
    Message-ID:  <20171122045652.2EE75FB40%cvs.NetBSD.org@localhost>

  |  Return EINVAL in vlan_config() when a VLAN ID is 0 or 65535.
  |  The spec states 0 and 65535 are reserved.

Tags are 12 bigs, so 0..4095 (65535 won't fit).   The code that was
added in this commit looks correct (0xfff - it would be better as a
named const defined somewhere) but the comment that accompanies it
(and this commit log entry) are not.

kre



Home | Main Index | Thread Index | Old Index