Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/lib/libm



On Mon, Aug 21, 2017 at 10:02:44AM +0000, Christos Zoulas wrote:
> In article <20170820110132.GA5164%britannica.bec.de@localhost>,
> Joerg Sonnenberger  <joerg%bec.de@localhost> wrote:
> >On Sun, Aug 20, 2017 at 04:25:47AM -0400, Christos Zoulas wrote:
> >> Module Name:	src
> >> Committed By:	christos
> >> Date:		Sun Aug 20 08:25:47 UTC 2017
> >> 
> >> Modified Files:
> >> 	src/tests/lib/libm: t_fe_round.c
> >> 
> >> Log Message:
> >> fix build (missing nexttoward on mips64 and aarch64)
> >
> >Please fix the actual problem and not just paper over it.
> 
> I am not papering over it. It is now a test failure not a build failure.
> The build can now proceed and we can actually fix more build/test failures.
> This has been broken for more than a week. It is the responsibility
> of the person who broke the build to fix it. You are shooting the messenger.

The problem with test failures is that they are not visible. Build
failures at least are, if they make sense. I don't understand many of
the current llvm build failures at all nor did I see mips64 and aarch64
recently, given that the latter moved...

Joerg


Home | Main Index | Thread Index | Old Index