Re: CVS commit: src/sys

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

On 2016/01/28 0:02, Taylor R Campbell wrote:
>    From: "Kengo NAKAHARA" <knakahara%netbsd.org@localhost>
>    Date: Tue, 26 Jan 2016 05:58:06 +0000
> 
>    BTW, It seems in_stf_input() had bugs...
> 
> Can you elaborate?  Your change to if_stf.c doesn't look quite right:
> you've made in_stf_encapsw follow the IPv6 input prototype, but it's
> still an IPv4/AF_INET protocol as it should be -- stf(4) encapsulates
> IPv6 packets inside IPv4 packets on the wire.
> 
> One thing that this explicit prototype business doesn't check,
> unfortunately, is whether the AF_* that you passed to encap_attach
> matches the .encapsw* member of the union that you initialized.

Sorry, it's my mistake. I fix it.


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Core Product Development Department,
Product Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>