Re: CVS commit: src/external/bsd/wpa/dist/src/drivers

[christos%zoulas.com@localhost (Christos Zoulas)]

On Jan 19,  5:43pm, roy%marples.name@localhost (Roy Marples) wrote:
-- Subject: Re: CVS commit: src/external/bsd/wpa/dist/src/drivers

| On 19/01/2016 15:22, Christos Zoulas wrote:
| > In article <20160119150829.60108FBB7%cvs.NetBSD.org@localhost>,
| > Roy Marples <source-changes-d%NetBSD.org@localhost> wrote:
| >> -=-=-=-=-=-
| >>
| >> Module Name:	src
| >> Committed By:	roy
| >> Date:		Tue Jan 19 15:08:29 UTC 2016
| >>
| >> Modified Files:
| >> 	src/external/bsd/wpa/dist/src/drivers: driver_bsd.c
| >>
| >> Log Message:
| >> Don't log RTM messages we aren't interested in at all.
| > 
| > But these were debugging printfs...
| 
| With normal services running as well (dhcpcd, unbound, etc)
| these RTM messages just muddy the water, especially as some of the more
| popular messages such as RTM_ADD just print RTM_??? (1) which tells me
| that wpa_supplicant expects to handle it but doesn't know about it which
| is wrong IMHO.

Well, why don't you add 'case RTM_ADD: break;' instead? Last time I was
debugging what was going on, I needed to add all this to figure out what
was happening. The hand-hurts, cut-hand approach is a little too drastic.

christos