Re: CVS commit: src/sys

[Nick Hudson <skrll%netbsd.org@localhost>]

On 08/17/15 07:16, Kengo NAKAHARA wrote:
> Module Name:	src
> Committed By:	knakahara
> Date:		Mon Aug 17 06:16:03 UTC 2015

Hi,

Unfortunately, the following doesn't work for platforms that don't define
interrupt_construct_intrids. Should a new stub that returns NULL be created?
Maybe RUN_ONCE is required here?

> Index: src/sys/kern/subr_interrupt.c
> diff -u /dev/null src/sys/kern/subr_interrupt.c:1.1
> --- /dev/null	Mon Aug 17 06:16:03 2015
> +++ src/sys/kern/subr_interrupt.c	Mon Aug 17 06:16:03 2015
...

> +/*
> + * Return the size of interrupts list data on success.
> + * Reterun 0 on failed.
> + */
> +static size_t
> +interrupt_intrio_list_size(void)
> +{
...
> +	/* il_line body */
> +	ii_handler = interrupt_construct_intrids(kcpuset_running);
> +	if (ii_handler == NULL)
> +		return 0;

...
> Index: src/sys/kern/kern_stub.c
> diff -u src/sys/kern/kern_stub.c:1.39 src/sys/kern/kern_stub.c:1.40
> --- src/sys/kern/kern_stub.c:1.39	Mon Apr 27 06:42:53 2015
> +++ src/sys/kern/kern_stub.c	Mon Aug 17 06:16:03 2015
...
> +__weak_alias(interrupt_construct_intrids, eopnotsupp);

I found this by running sysctl -A on an evbarm platform

Nick