re: CVS commit: src/sys/kern

[matthew green <mrg%eterna.com.au@localhost>]

"Masao Uebayashi" writes:
> Module Name:	src
> Committed By:	uebayasi
> Date:		Tue Aug 18 13:46:20 UTC 2015
> 
> Modified Files:
> 	src/sys/kern: kern_cpu.c kern_drvctl.c
> 
> Log Message:
> Convert pseudo attach functions to take no arguments, as some functions
> (pppattach(), putterattach(), etc.) already do.  This means that pseudo
> attach function will be able to become a constructor.

how does this work?

these functions are called by ioconf.c that generated by config(1),
so i'm not sure how this can not be a build break, or at least a
confusing and inconsistent.

ioconf.c:void drvctlattach(int);
ioconf.c:const struct pdevinit pdevinit[] = {
...
ioconf.c:       { drvctlattach, 1 },

subr_autoconf.c:     for (pdev = pdevinit; pdev->pdev_attach != NULL; pdev++)
subr_autoconf.c:             (*pdev->pdev_attach)(pdev->pdev_count);

what's the plan here?  this reduction won't work for a number of
basic pdevs (like raid(4)) without updating it to not use the
count argument.


.mrg.