Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libpthread



On 26/06/15 07:04, Nick Hudson wrote:
On 06/26/15 02:33, Antti Kantee wrote:
+# ifdef __CPU_SIMPLE_LOCK_PAD
+#  define __pthread_spin_t unsigned char
+# else
+#  define __pthread_spin_t unsigned int
+# endif

Are you sure this "works" for hppa which has funky __cpu_simple_lock_t?

You're right, it doesn't, I should've checked more carefully before commit. I improved the definition to not depend on __CPU_SIMPLE_LOCK_PAD and use sizeof+alignof instead. That will keep all ports happy, regardless of how they define __cpu_simple_lock_t and assume it to be aligned.

Thanks for catching it.


Home | Main Index | Thread Index | Old Index