Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: [netbsd-7] src/sbin/raidctl



In article <20150608204801.C85E79A%cvs.netbsd.org@localhost>,
Soren Jacobsen <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	snj
>Date:		Mon Jun  8 20:48:01 UTC 2015
>
>Modified Files:
>	src/sbin/raidctl [netbsd-7]: raidctl.c
>
>Log Message:
>Pull up following revision(s) (requested by manu in ticket #827):
>	sbin/raidctl/raidctl.c: revision 1.58
>Better sanity check numbers given to raidctl(8)
>Replace atoi(3) by strtol(3), and check that numbers are valid,
>positive, and in int32_t range. The previous lack of check could
>silently lead to the same serial being set to all RAID volumes
>for instance because given numbers were bigger than INT_MAX. The
>consequence is in an awful mess when RAIDframe would mix volumes...

This has typos and it is easier to use strtou like in the next version.

christos



Home | Main Index | Thread Index | Old Index