Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: [nick-nhusb] src/sys/dev/usb



On 2015/03/06 21:55, Nick Hudson wrote:
On 03/06/15 11:36, Takahiro HAYASHI wrote:
On 2015/03/05 21:39, Nick Hudson wrote:
Modified Files:
    src/sys/dev/usb [nick-nhusb]: usbdi.c

Log Message:
Minor USBHIST_LOG changes

    /* Sync transfer, wait for completion. */
    if (err != USBD_IN_PROGRESS) {
-        USBHIST_LOG(usbdebug, "<- done xfer %p, not in progress", xfer,
+        USBHIST_LOG(usbdebug, "<- done xfer %p, err %d (complete/error)", xfer,
            0, 0, 0);
        return err;
    }

Do you want to print 'err' instead of 0?

Fixed. Thanks.

BTW, typeof err is usbd_status so ENOMEM is not suitable.



I fixed one place where this was a problem - did you spot others?

usbd_do_request_flags_pipe returns ENOMEM around line 1084
but it should return usbd_status.


Thanks,
--
t-hash


Home | Main Index | Thread Index | Old Index