Re: CVS commit: src/usr.bin/pwait

[christos%astron.com@localhost (Christos Zoulas)]

In article <20150303003710.GA20580%britannica.bec.de@localhost>,
Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
>On Mon, Mar 02, 2015 at 04:43:39PM -0500, Christos Zoulas wrote:
>> Module Name:	src
>> Committed By:	christos
>> Date:		Mon Mar  2 21:43:39 UTC 2015
>> 
>> Added Files:
>> 	src/usr.bin/pwait: Makefile pwait.1 pwait.c
>> 
>> Log Message:
>> Add pwait, from FreeBSD
>
>Please don't just import programs without asking for feedback on the
>appropiate lists. For example, why does this program not have a timeout
>option? I guess I am not the only programmer here with a process monitor
>written based on kqueue and *this* tool has both ugly warts (matching
>against /proc for Solaris compat, seriously?) and limitations.

It is easy enough to add (the timeout). Even if we add it, we would
add it post import to keep local differences separate. The solaris
compat is not even documented (was it worth removing? I don't think
so). It is a useful tool and this code provided a nice starting
point.

I was actually thinking about the timeout implementation (using the
kevent timeout or using SIGALRM) and I have not decided yet. What do
you think?

christos