Re: CVS commit: src/sys/arch/sparc64/include

[David Laight <david%l8s.co.uk@localhost>]

On Thu, Dec 25, 2014 at 02:02:04PM +0000, Takeshi Nakayama wrote:
> Modified Files:
> 	src/sys/arch/sparc64/include: psl.h
> 
> Log Message:
> Put "memory" to asm inline for reading privilege registers on sun4v
> to avoid issuing rdpr %ver before checking cputyp as a result of
> code moving by compiler optimization.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.55 -r1.56 src/sys/arch/sparc64/include/psl.h

Is that the correct fix?
Unless the rdpr actually accesses memory (don't think it does) then
then problem is probably a missing 'volatile' instead.

Certainly the way those asm functions are defined looks to be
rather more obfuscated than necessary.

	David

-- 
David Laight: david%l8s.co.uk@localhost