Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/atari/stand/installboot



mrg@ wrote:

> Nick Hudson writes:
> > > Log Message:
> > > Specify -fno-strict-aliasing as a temporary workaround for gcc48.
 :
> > > Should be pulled up to netbsd-7 if we switches m68k to using gcc48.
> > >
> > Why not pullup in anticipation?

Because it doesn't give any visible benefits (except theoretical
correctness) for future release users, if we choose gcc45 for netbsd-7?

> infact, given the strict aliasing violations in this file, there
> is no guarantee that GCC 4.5 isn't miscompiling it already just
> without the additional warnings in 4.8...
> 
> ie, this seems sane regardless of what happens.  same for -6?

I don't think it's worth because binaries have worked without changes.
(if the compiler tries reorder optimization per strict-aliasing rule
 I guess wrong implementation will be warned at that time)

IMO, all changes against release branches should have visible benefits
(fixing errors, adding new features, to make future pullups easier etc)
per possible botches.

Anyway it has less priority in my todo to test it with gcc45.
If someone[TM] can test builds etc. and send a pullup request,
it's no problem for me.

---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index