Re: CVS commit: src/sys/sys

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Nov 17, 2014 at 08:50:20AM -0500, Christos Zoulas wrote:
> On Nov 17,  7:56am, martin%homeworld.netbsd.org@localhost (Martin Husemann) wrote:
> -- Subject: Re: CVS commit: src/sys/sys
> 
> | On Sun, Nov 16, 2014 at 09:27:26PM -0500, Christos Zoulas wrote:
> | > Module Name:	src
> | > Committed By:	christos
> | > Date:		Mon Nov 17 02:27:26 UTC 2014
> | > 
> | > Added Files:
> | > 	src/sys/sys: clock.h
> | > 
> | > Log Message:
> | > PR/49207: Kamil Rytarowski: Centralize and rename a bunch of clock constants
> | > and inline functions.
> | 
> | Why inline functions? None of these are used often or time critical.
> 
> I was thinking the same. We could put them in common/ somewhere.

I don't agree, for most the complexity of the call doesn't justify the
extra code, so inline is fine. That said, days_in_month is quite
wasteful with using an array of int...

Joerg