Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/atari/stand/installboot



christos@ wrote:

> | > but memcpy is the only way.
> | 
> | - cast via (void *)
> 
> That does not work.

Hmm. How about -fno-strict-aliasing?

> | - union {uint16_t w[256]; struct bootblock bbp;}
> 
> That works...
> 
> | - be16enc(9)
> 
> I don't see how that helps...

There are two points:

- The port page says "keeping it working is the responsibility of the
  user community" for Tier II port, and there is a user who has a real
  machine and said "I'll check tomorrow", so you don't have to rush to
  commit fixes you cannot test.

- The MD installboot implementation heavily depends on hardware specific
  features but there are few documents and descriptions about such hardware
  except existing source code, so it's much more important to keep
  intention of the original author in such MD code for future readers
  than appeasing strict modern compilers by mechanical changes.
  Furthermore, unexpected bugs could often slip in by such untested
  mechanical changes and it makes harder to track problems in future.

I'm still trying to get atari booting with HAVE_GCC=48,
but there are still more problems...
(sysinst floppy overflow, sed(1) in the install floppy dumps core, etc)

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index