Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern



On Mon, Aug 18, 2014 at 04:49:17AM +0000, Christos Zoulas wrote:
> In article <20140817230358.6B94241%cvs.netbsd.org@localhost>,
> Chuck Silvers <source-changes-d%NetBSD.org@localhost> wrote:
> >-=-=-=-=-=-
> >
> >Module Name: src
> >Committed By:        chs
> >Date:                Sun Aug 17 23:03:58 UTC 2014
> >
> >Modified Files:
> >     src/sys/kern: exec_elf.c
> >
> >Log Message:
> >eliminate COMPAT_OLDNOTE and just always recognize the old notes.
> 
> I don't think I like this, because it allows for sloppy note handling.
> If we had this code, we would have not found the incorrect note handling
> in "go". If I don't care about running old binaries, I should expect to
> have correct notes.

my interpretation of our earlier email discussion was that the old notes
were correct and treating them the same as the current notes was fine,
but the current exec code was being overly strict by calling them invalid.
the difference in to code to honor them or not is "<" vs. "!=",
so there seemed no harm in doing it all the time.

I'm not aware of the issue with "go", could you explain?

-Chuck


Home | Main Index | Thread Index | Old Index