Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



Hi Alexander,

On Sat, Jul 19, 2014 at 4:39 PM, Alexander Nasonov <alnsn%yandex.ru@localhost> 
wrote:
> Lourival Pereira Vieira Neto wrote:
>> Module Name:  src
>> Committed By: lneto
>> Date:         Sat Jul 19 17:13:22 UTC 2014
>>
>> Modified Files:
>>       src/sys/modules/lua: lua.c
>>       src/sys/sys: lua.h
>>
>> Log Message:
>> lua(4): added support for running Lua scripts in intr context
>
> Please revert this.

Sure; if other developers want it too, I can revert this.

BTW, rmind@ and mbalmer@ have OKed this.

> You can't make a mechanical change
> (s/kmem_/kmem_intr_/g and so on) to enable lua in softintr
> context. You need to design it.

IMO, it is not a mechanical change. It is an incremental one.

> What if GC kicks-in in softintr?

It will call kmem_intr_free(9).

> What if the code tries to
> load a chunk of new code in softintr?

What if? Have you tried that already?

> And there are other
> questions.

You can formulate these questions and help to improve this work.

Regards,
-- 
Lourival Vieira Neto


Home | Main Index | Thread Index | Old Index