Re: CVS commit: src/sys/arch/sgimips/dev

[Michael <macallan%netbsd.org@localhost>]

Hello,

On Tue, 03 Jun 2014 06:56:38 +1000
matthew green <mrg%eterna.com.au@localhost> wrote:

> 
> "Michael Lorenz" writes:
> > Module Name:        src
> > Committed By:       macallan
> > Date:               Mon Jun  2 15:07:24 UTC 2014
> > 
> > Modified Files:
> >     src/sys/arch/sgimips/dev: int.c
> > 
> > Log Message:
> > sprinkle __unused()
> 
> hmmm, these seems wrong:
> 
> !       int __unused(startmsb), __unused(lsb), msb;
> 
> startmsb is unused, and seems can just be deleted as well
> as the assignment to it.

True.

> lsb is only used as a return value from bus_space_read_1()
> and can also be deleted and (void) written before the call
> to bus_space to signify we know we're ignoring it.

Yeah, I forgot about that one ( and didn't want to change any more than
absolutely necessary in code I'm not sure I can test properly )

have fun
Michael