Re: CVS commit: src/sys/arch

[Klaus Klein <kleink%kleink.org@localhost>]

On Wed, Apr 10, 2013 at 08:57:37PM -0400, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date:         Thu Apr 11 00:57:36 UTC 2013
> 
> Modified Files:
>       src/sys/arch/alpha/include: limits.h
>       src/sys/arch/amd64/include: limits.h
>       src/sys/arch/arm/include: limits.h
>       src/sys/arch/hppa/include: limits.h
>       src/sys/arch/i386/include: limits.h
>       src/sys/arch/ia64/include: limits.h
>       src/sys/arch/m68k/include: limits.h
>       src/sys/arch/mips/include: limits.h
>       src/sys/arch/powerpc/include: limits.h
>       src/sys/arch/sh3/include: limits.h
>       src/sys/arch/sparc/include: limits.h
>       src/sys/arch/vax/include: limits.h
> 
> Log Message:
> add missing SSIZE_MIN

What's the purpose of this?  ssize_t is meant to be "a count of
bytes or an error indication", so having SSIZE_MIN doesn't make
sense.  Nor does its only in-tree, broken use in libevent; searching
outside our tree I wasn't able to come up with a use of EV_SSIZE_MIN
except for the aforementioned regression test.

(I'll be the first to admit I'm somewhat late in voicing my concerns,
but I was ... busy.  *sigh*)


- Klaus