Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Wed, Feb 19, 2014 at 03:50:03PM +0000, Christos Zoulas wrote:
> In article <20140218222457.GA1915%britannica.bec.de@localhost>,
> Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
> >On Tue, Feb 18, 2014 at 03:54:34PM -0500, Christos Zoulas wrote:
> >> Module Name:       src
> >> Committed By:      christos
> >> Date:              Tue Feb 18 20:54:34 UTC 2014
> >> 
> >> Modified Files:
> >>    src/sys/external/bsd/compiler_rt/dist/lib: int_util.h
> >> 
> >> Log Message:
> >> prefer __func__ instead of __FUNCTION__
> >
> >Can we please avoid cosmetic local changes?
> 
> Do we want portable code or not? And if we can't improve the local code
> what's the point of importing it?

I have no problem with going over the code in the upstream repository,
but I have a problem with adding pointless local changes. They just
increase the cost of maintainance for absolute no good reason.

Joerg