Re: CVS commit: src/distrib/common

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

matt@ wrote:

> > matt@ wrote:
> > 
> >> Module Name:       src
> >> Committed By:      matt
> >> Date:              Sat Feb  1 21:05:54 UTC 2014
> >> 
> >> Modified Files:
> >>    src/distrib/common: Makefile.crunch
> >> 
> >> Log Message:
> >> Pass DBG to crunchgen so it can get into the created mk file.
> > 
> > I think it should be set by each Makefile via CRUNCHGEN_FLAGS
> > (several mips ports already have it), not in the common Makefile.
> 
> Most ramdisk Makefiles have a DBG=<value> which is ignored.
> CRUNCHGEN_FLAGS is unobvious.

Most, but not all.

The point is that your changes disallow each Makefile overwriting
default settings.  At least it should be set via
CRUNCHGEN_FLAGS?= -d "${DBG}"
in the common Makefile.crunch.

Or properly remove all redundant CRUNCHGEN_FLAGS which specify -d
from existing Makefiles if you really don't like it.

---
Izumi Tsutsui