Re: CVS commit: src/lib/libc/time

[Klaus Klein <kleink%kleink.org@localhost>]

Am 14.12.2013 um 12:32 schrieb Martin Husemann 
<martin%homeworld.netbsd.org@localhost>:

> On Fri, Dec 13, 2013 at 05:34:47AM -0500, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:        christos
>> Date:                Fri Dec 13 10:34:47 UTC 2013
>> 
>> Modified Files:
>>      src/lib/libc/time: localtime.c
>> 
>> Log Message:
>> add a cast for sparc64 where int_fast32_t is long (should it be?), and
> 
> No, it shouldn't, especially when uint_fast32_t is 32bit only.
> At least I don't see any reason not to make it int. Anyone else?

ISTR the cost of sign extension being the reason for sparc64’s signed fast 
types being 64-bit. That implementation is not unreasonable, and well within 
the spec.


- Klaus