Re: CVS commit: src/usr.sbin/mtree

[Paul Goyette <paul%whooppee.com@localhost>]

On Wed, 2 Jan 2013, Christos Zoulas wrote:

> On Jan 2, 10:19am, martin%homeworld.netbsd.org@localhost (Martin Husemann) 
> wrote:
> -- Subject: Re: CVS commit: src/usr.sbin/mtree
>
> | On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote:
> | > Module Name:     src
> | > Committed By:    christos
> | > Date:            Thu Dec 20 16:43:17 UTC 2012
> | >
> | > Modified Files:
> | >  src/usr.sbin/mtree: create.c extern.h mtree.8 mtree.c spec.c
> | >
> | > Log Message:
> | > Implement the "flavor" output discussed in tech-userlevel@, by Brooks Davis
> | >
> | >
> | > To generate a diff of this commit:
> | > cvs rdiff -u -r1.67 -r1.68 src/usr.sbin/mtree/create.c
> | > cvs rdiff -u -r1.36 -r1.37 src/usr.sbin/mtree/extern.h
> | > cvs rdiff -u -r1.64 -r1.65 src/usr.sbin/mtree/mtree.8
> | > cvs rdiff -u -r1.43 -r1.44 src/usr.sbin/mtree/mtree.c
> | > cvs rdiff -u -r1.84 -r1.85 src/usr.sbin/mtree/spec.c
> |
> | This broke the mtree atf tests. Output now differs by additional size
> | values for symlinks and directories:
> |
> | -2               type=dir nlink=2
> | +2               type=dir nlink=2 size=0
> |
> |
> | See for example:
> | 
> http://www.netbsd.org/~martin/sparc64-atf/147_atf.html#usr.sbin_mtree_t_mtree_create
>
> Yes, we agreed to change the format for the default and if you want the 
> backwards
> compatible one, we you need to say netbsd flavor.

Seems to me we to get the tests updated

* to reflect the changes in expected output, and also
* additional test cases to ensure that "compatability mode" works 
correctly.


> christos
>
> !DSPAM:50e43a9b17431864914745!

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------