Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/pkill



In article <20121121080326.GL508%snowdrop.l8s.co.uk@localhost>,
David Laight  <david%l8s.co.uk@localhost> wrote:
>On Tue, Nov 20, 2012 at 05:52:02PM -0500, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:        christos
>> Date:                Tue Nov 20 22:52:02 UTC 2012
>> 
>> Modified Files:
>>      src/usr.bin/pkill: pkill.c
>> 
>> Log Message:
>> Don't use p_comm since it is only 16 characters long and you can find the
>> full argv[0]. It is just confusing to have a long command name, that ps
>> shows as the long command name, and then when you try to kill it using
>> the full command name as displayed you don't get a match. While there
>> fix a format nit, and remove the main() declaration.
>
>This might break some scripts.

Well, I could put backwards compatibility, but it is more dangerous to
do so in the long term. Kids: don't use pkill(1) in scripts.

christos



Home | Main Index | Thread Index | Old Index