Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



   Date: Wed, 9 May 2012 07:54:42 +0000
   From: Martin Husemann <martin%homeworld.netbsd.org@localhost>

   On Wed, May 09, 2012 at 12:16:08AM +0000, Taylor R Campbell wrote:
   > Adapt tmpfs_rename to use genfs_rename.

   This seems to break kqueue, see /usr/tests/fs/tmpfs

      cd /usr/tests/fs/tmpfs && atf-run t_rename | atf-report

Oops, looks like I forgot to carry over a line from the previous
tmpfs_rename.  This should fix it.  Will commit later today if nobody
beats me to it.  Thanks!

(I think knotes are hosed in most of our file systems; tmpfs may be
the exception...  Also, these kqueue tests should be adapted to not
require root, like the fs/vfs tests -- that's why I didn't run them
before.)

Index: tmpfs_rename.c
===================================================================
RCS file: /cvsroot/src/sys/fs/tmpfs/tmpfs_rename.c,v
retrieving revision 1.1
diff -p -u -r1.1 tmpfs_rename.c
--- tmpfs_rename.c      9 May 2012 00:16:07 -0000       1.1
+++ tmpfs_rename.c      9 May 2012 11:23:04 -0000
@@ -373,6 +373,8 @@ tmpfs_gro_rename(struct mount *mp, kauth
                VP_TO_TMPFS_NODE(tdvp)->tn_status |= TMPFS_NODE_MODIFIED;
        }
 
+        VN_KNOTE(fvp, NOTE_RENAME);
+
 #if 0                          /* XXX */
        genfs_rename_cache_purge(fdvp, fvp, tdvp, tvp);
 #endif


Home | Main Index | Thread Index | Old Index