Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

lfs_cleanerd: load_threshold should be double (was: CVS commit: src)



On Thu, 12 Apr 2012 11:46:17 +0000,
"Joerg Sonnenberger" <joerg%netbsd.org@localhost> wrote:

> Module Name:  src
> Committed By: joerg
> Date:         Thu Apr 12 11:46:17 UTC 2012
> 
> Modified Files:
>       src/libexec/lfs_cleanerd: lfs_cleanerd.c
<snip>
> 
> Log Message:
> Don't assign non-integral constants to integral variables.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.29 -r1.30 src/libexec/lfs_cleanerd/lfs_cleanerd.c
<snip>

lfs_cleanerd.c:load_threshold should be double, because it is compared
with loadavg which is double.

diff -u lfs_cleanerd.c.ORIG lfs_cleanerd.c
--- lfs_cleanerd.c.ORIG 2012-04-12 20:46:16.000000000 +0900
+++ lfs_cleanerd.c      2012-04-15 23:38:50.000000000 +0900
@@ -1,1 +1,1 @@
-/* $NetBSD: lfs_cleanerd.c,v 1.30 2012/04/12 11:46:16 joerg Exp $       */
+/*     $NetBSD$         */
@@ -67,7 +67,7 @@
 /* XXX these top few should really be fs-specific */
 int use_fs_idle;       /* Use fs idle rather than cpu idle time */
 int use_bytes;         /* Use bytes written rather than segments cleaned */
-int load_threshold;    /* How idle is idle (CPU idle) */
+double load_threshold; /* How idle is idle (CPU idle) */
 int atatime;           /* How many segments (bytes) to clean at a time */
 
 int nfss;              /* Number of filesystems monitored by this cleanerd */
@@ -1365,7 +1365,7 @@
         */
        atatime  = 1;
        segwait_timeout = 300; /* Five minutes */
-       load_threshold  = 0;
+       load_threshold  = 0.2;
        stat_report     = 0;
        inval_segment   = -1;
        copylog_filename = NULL;

Cheers,
-- 
nakayosh


Home | Main Index | Thread Index | Old Index