Re: CVS commit: src/etc

[Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>]

On 06.09.2011 21:29, Thomas Klausner wrote:
>> If the source ('-s' of postinstall(8)) is not specified at command line,
>> according to code it takes "/usr/src" as default. Do you have a
>> stale/old rc.conf(5) file in there, /usr/src/etc/defaults/rc.conf?
> 
> I have the CVS checkout there that was used to build the snapshot I
> installed, so yes there is a file there but no it is not stale.
> 
>> Now, if this case should be handled properly is another question. There
>> are multiple solutions, all of them end up tweaking postinstall(8):
>> - raise a warning when overriding certain configuration files with older
>> versions (perhaps by using the CVS tags?)
> 
> It's not an older version.
> 
>> - make source an explicit arg to etcupdate/postinstall
>> - something else?
> 
> Or perhaps prefer ./etc to /usr/src/etc, that would solve the issue
> for me at least :)

postinstall(8) and etcupdate(8) all take /usr/src/ as default, so I
won't change that.

The problem is that rc.conf is now generated at build time, and I am
always using postinstall(8) via -s /usr/cvs/dest (my default DESTDIR),
so this went unnoticed during my tests as the correct /etc/defaults gets
parsed.

I'll add the required code to handle this; thanks for reporting!

-- 
Jean-Yves Migeon
jeanyves.migeon%free.fr@localhost