re: CVS commit: src/usr.sbin/envstat

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 5 Jun 2011, matthew green wrote:

> > Module Name:    src
> > Committed By:   pgoyette
> > Date:           Sat Jun  4 13:29:03 UTC 2011
> >
> > Modified Files:
> >         src/usr.sbin/envstat: envstat.c
> >
> > Log Message:
> > Since there is no longer a value-avg property, remove the code that
> > extracts it.
>
> what's the behaviour of old envstat and new kernel?

Old envstat simply retrieved the value_avg from the returned prop-dict 
(if the value was exported by the kernel) but never used the resulting 
value.

Furthermore, the value_avg field was exported, if and only if the 
ENVSYS_FVALID_AVG flag was set.  Nothing ever sets the flag, and the 
only use of value_avg is within dev/pci/arcmsr.c where it is used for a 
purpose totally unrelated to sysmon (it is used to correlate the sensor 
to a raidset member).

So ...

The value was never exported, but even if it had been, it would have 
been ignored.  I simply cleaned up to remove the code that would never 
get triggered.


-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------