Re: CVS commit: src

[David Laight <david%l8s.co.uk@localhost>]

On Thu, May 26, 2011 at 11:32:51AM -0500, David Young wrote:
> On Thu, May 26, 2011 at 06:10:42PM +0200, Lars Heidieker wrote:
> > On 05/26/11 06:25, Masao Uebayashi wrote:
...
> > with those changes I can't compile a kernel without USERCONF option set.
> > The changes in x86_machdep.c should be with in if defs on that options
> > 
> > Ok to commit the attached patch?
> 
> Conditional compilation clutters the code up.  What if instead you add
> to kern_stub.c,
> 
> #include <sys/userconf.h>
> __weak_alias(userconf_bootinfo, voidop);

I'd either:
    leave userconf_bootinfo() defined but with no body
or:
    #define userconf_bootinfo()
(or maybe both!)

        David

-- 
David Laight: david%l8s.co.uk@localhost