Re: CVS commit: src/tests/syscall

[christos%zoulas.com@localhost (Christos Zoulas)]

On May 22, 12:28am, jmmv%julipedia.org@localhost (Julio Merino) wrote:
-- Subject: Re: CVS commit: src/tests/syscall

| atf-test-case(4) contains a description of these.  (Yeah, it could be 
| improved.)

Good.

| > I don't see why. You just put it all in a shared library written in c and
| > used from c++. Shell you have already.
| 
| That's what was done.  But in order to enforce the timeouts et. al. this 
| library had to fork() on every test case.  This was really, really ugly 
| (and slow) in shell.  It was also hard to keep the 3 implementations (c, 
| c++, shell) in sync.

You should not have to fork if you don't set a timeout. Or you can fork
just one killer and have it timeout in 2x the last registered timeout and exit.
It listens to a socket for pid's and timeouts; if the socket is still
useable after the timeout it kills.

| I'm not saying it's not possible, just that it was ugly _in the past_. 
| We can revisit this later.  The renewed runtime I'm working on (atf v2, 
| aka kyua) will support different test program styles, so we should be 
| able to easily re-experiment with this approach.

Yes, the implementation needs to be done carefully.

christos