Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/csu



On Mon, Jan 31, 2011 at 11:05:23PM +0100, Joerg Sonnenberger wrote:
 > -static char curdir[MAXPATHLEN + 1]; /* startup directory */
 > +char curdir[MAXPATHLEN + 1];        /* startup directory */
 >   [...]
 > -    Var_Set(".PARSEDIR", ".", VAR_GLOBAL, 0);
 > +    extern char curdir[];
 > +    Var_Set(".PARSEDIR", curdir, VAR_GLOBAL, 0);

Please don't make messes like that; if you really need to extern it
put it in one of the header files.

However, as I recall it ought to work ok to do

    Var_Set(".PARSEDIR", "$(.CURDIR)", VAR_GLOBAL, 0);

instead.

However, this still isn't a correct fix as it doesn't take care of the
case when e.g. including ../Makefile.inc.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index