Re: CVS commit: src/sys/arch/hppa

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

Did you check that a kernel still builds?

I'll respond more fully later...

Nick

Sent from my iPhone

On 14 Nov 2010, at 12:30, Masao Uebayashi <uebayasi%tombi.co.jp@localhost> 
wrote:

> On Sun, Nov 14, 2010 at 10:36:26AM +0000, Nick Hudson wrote:
>> On Sunday 14 November 2010 03:16:05 Masao Uebayashi wrote:
>>> Module Name:    src
>>> Committed By:    uebayasi
>>> Date:        Sun Nov 14 03:16:05 UTC 2010
>>> 
>>> Modified Files:
>>>    src/sys/arch/hppa/hppa: pmap.c
>>>    src/sys/arch/hppa/include: mutex.h vmparam.h
>>> 
>>> Log Message:
>>> Don't rely on global APIs from internal.
>> 
>> Why is this change necessary?
>> 
>> Thanks,
>> Nick
> 
> To reduce unnecessary dependencies.  kmutex_t is for users.
> machine/mutex.h is internal, it knows what it's typedef'ed from.
> All other machine/mutex.h uses struct kmutex.  Do you have a specific
> reason to use kmutex_t?
> 
> vm_page_md should be moved to machine/pmap.h too.  It's not really
> a "parameter".
> 
>>> 
>>> 
>>> To generate a diff of this commit:
>>> cvs rdiff -u -r1.78 -r1.79 src/sys/arch/hppa/hppa/pmap.c
>>> cvs rdiff -u -r1.9 -r1.10 src/sys/arch/hppa/include/mutex.h
>>> cvs rdiff -u -r1.16 -r1.17 src/sys/arch/hppa/include/vmparam.h
>>> 
>>> Please note that diffs are not public domain; they are subject to the
>>> copyright notices on the relevant files.
>>>