Re: CVS commit: src/sys/arch/mips/mips

[Simon Burge <simonb%NetBSD.org@localhost>]

Antti Kantee wrote:

> On Tue Nov 09 2010 at 13:10:02 +1100, Simon Burge wrote:
> > David Holland wrote:
> > 
> > > On Mon, Nov 08, 2010 at 06:09:39PM +0000, Antti Kantee wrote:
> > >  > Modified Files:
> > >  >        src/sys/arch/mips/mips: locore_mips1.S
> > >  > 
> > >  > Log Message:
> > >  > In TLBRead, restore PID before doing the saves so that the caller's
> > >  > TLB entries are used instead of the PID given as the argument.
> > >  > 
> > >  > from Alessandro Forin
> > > 
> > > [ ... ]
> > > 
> > > Do you have any further explanations or reports of symptoms? I don't
> > > see anything on any of the mips lists.
> > 
> > I'm curious about this too.  That code hasn't changed for at least
> > 14 years...
> 
> Given that it's only called from ddb, i'm not too surprised nobody has
> noticed.  Now, unless someone argues that the stores should definitely
> happen with the arbitrary PID set up by tlbr, let's flag the change as
> "obvious", get on with something useful, and leave noppy philosophy to
> some other book club.

Thanks for the extra details.  It may be "obvious" with the background
info you've now provided, but wasn't from your initial commit message.

Cheers,
Simon.