Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/audiocfg



In article <20100903192037.C6AA5175D0%cvs.netbsd.org@localhost>,
Jared D. McNeill <source-changes-d%NetBSD.org@localhost> wrote:

[...]

>               if (wlen > buflen)
>                       wlen = buflen;
>-              write(adev->fd, (char *)buf + off, wlen);
>+              wlen = write(adev->fd, (char *)buf + off, wlen);
>+              if (wlen == -1) {
>+                      perror("write");
>+                      rv = -1;
>+                      goto done;
>+              }

Should we make perror() produce a warning so people will stop using it?
Please use warn{,x}() instead, so we get the program name printed!

christos



Home | Main Index | Thread Index | Old Index