Re: CVS commit: src/sys/arch

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On 24.07.10 02:45, Jean-Yves Migeon wrote:
> Module Name:  src
> Committed By: jym
> Date:         Sat Jul 24 00:45:57 UTC 2010
> 
> Modified Files:
>       src/sys/arch/i386/conf: GENERIC
>       src/sys/arch/i386/i386: bioscall.S kvm86call.S locore.S machdep.c
>           mptramp.S multiboot.c
>       src/sys/arch/i386/include: pmap.h
>       src/sys/arch/x86/include: cpu.h pmap.h
>       src/sys/arch/x86/x86: cpu.c pmap.c
>       src/sys/arch/xen/x86: cpu.c x86_xpmap.c xenfunc.c
> 
> Log Message:
> Welcome PAE inside i386 current.
> 

Great work!

[...]

> XXX kvm(3) will be fixed in another patch to properly handle both PAE and !PAE
> kernel dumps (VA => PA macros are slightly different, and need proper 64 bits
> PA support in kvm_i386).
> 
> XXX Mixing PAE and !PAE modules may lead to unwanted/unexpected results. This
> cannot be solved easily, and needs lots of thinking before being declared
> safe (paddr_t/bus_addr_t size handling, PD/PT macros abstractions).
> 

How about making paddr_t always 64bit? That makes it much easier to deal
with in libkvm.

paddr_t being always 64bit wide also allows to switch PAE on and off at
runtime like Solaris does.

Pleaes fix the amd64 build error reported on current-users@.
The build error is related to rump.

Christoph