Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/uvm



> > Log Message:
> > uvm_fault: Pack variables shared during fault / re-fault into a struct named
> > uvm_faultctx.  Unfortunately ~all of those values are overriden in various
> > ways.  Constification doesn't help much...
> 
> Isn't that what uvm_faultinfo is for?  Why are you inventing a new structure?

I thought uvm_faultinfo was there for uvmfault_lookup() and other various
functions to omit arguments.  It's a public structure.  My intent is to
consolidate variables (state) kept in one fault, especially across re-faults.
Those state is internal to uvm_fault.  Exposing the internal seems odd to
me.

(But yes, the name is confusing.)

Masao


Home | Main Index | Thread Index | Old Index