Re: CVS commit: src/sys/compat/netbsd32

[Matt Thomas <matt%3am-software.com@localhost>]

On Dec 10, 2009, at 1:12 PM, Nicolas Joly wrote:

> On Fri, Dec 11, 2009 at 06:17:36AM +1100, matthew green wrote:
>> 
>>   Module Name:       src
>>   Committed By:      njoly
>>   Date:              Thu Dec 10 14:58:28 UTC 2009
>> 
>>   Modified Files:
>>      src/sys/compat/netbsd32: netbsd32_ioctl.c
>> 
>>   Log Message:
>>   Make netbsd32_from_{ifreq,oifreq}() copy the whole structure, not only
>>   the interface name. Finally fix my own PR/39424.
>> 
>>   ok by christos.
>> 
>> 
>> this uses the size of the non-compat version to copy, which leads to
>> it copying beyond the allocated space doesn't it?  ie, it should be:
>> 
>>      memcpy(s32p, p, sizeof *s32p);
>> 
>> shouldn't it?
> 
> It should not be a problem as both native and compat netbsd32
> ifreq/oifreq structures have the same size.

Then add a CTASSERT to that effect.