Re: CVS commit: src/sys/dev/gpio

["Perry E. Metzger" <perry%piermont.com@localhost>]

Arnaud Lacombe <lacombar%gmail.com@localhost> writes:
> On Sun, Jul 26, 2009 at 5:26 PM, matthew green<mrg%eterna.com.au@localhost> 
> wrote:
>> incidentially, i actually did object to this change on ICB last night
>> but i was off to bed and didn't feel like arguing at the time.  i
>> didn't expect to see it commited straight away.  so marc's claim that
>> it did not get any objections is infact not entirely right.
>>
> OOTH, it's not like the code in question was already heavily used:
>
> -/* $NetBSD: gpiosim.c,v 1.1 2009/07/25 16:17:10 mbalmer Exp $ */
> +/* $NetBSD: gpiosim.c,v 1.2 2009/07/26 13:45:20 mbalmer Exp $ */
>

And in addition to being less than 24 hours old, the code was his own
code. The clear de facto rule is that you can change code you wrote and
own with a lot less approval, even for a new developer, than other stuff
requires.

I'm equally upset that Tonnerre sent him a public rebuke. He could have
said, in private, "hey, thanks for the enthusiasm, though FYI, you
should still be checking stuff with your mentors" -- but instead he was
very cold about it and did it in public. Neither of those is acceptable.

> I join perry@ on this thread, and chritos@ too as this should have
> been privately discussed.

Violent agreement all around.

Perry
-- 
Perry E. Metzger                perry%piermont.com@localhost