Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



perry%piermont.com@localhost wrote:

> Andrew Doran <ad%netbsd.org@localhost> writes:
> > On Tue, Jun 23, 2009 at 07:36:41PM +0000, Elad Efrat wrote:
> >
> >> Log Message:
> >> Move the implementation of vaccess() to genfs_can_access(), in line with
> >> the other routines of the same spirit.
> > ...
> >> No objections on tech-kern@:
> >> 
> >>    http://mail-index.netbsd.org/tech-kern/2009/06/21/msg005310.html
> >
> > 48 hours is not long enough, it has been raised with you before. Are you
> > deliberately trying to piss everyone off? Because it certainly comes over
> > that way.
> 
> Two days without comments isn't always unreasonable, is it?

- stupid comments would often make nothing better, as you've seen
- it would take more than two days to put worth comment with
  proper code review (it depends on size of the changes, of course)
- it's reasonable for me that we should wait at least a week
  before to consider "no response means no objections."

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index