Re: CVS commit: src/crypto/external/bsd/netpgp/dist

[christos%astron.com@localhost (Christos Zoulas)]

In article <20090525160949.GR14908%nef.pbox.org@localhost>,
Alistair Crooks  <agc%pkgsrc.org@localhost> wrote:
>Hi Arnaud, everyone,
>
>On Thu, May 21, 2009 at 10:59:04PM -0400, Arnaud Lacombe wrote:
>> I've been seeing a lot of commit and activity in netpgp. Do you mind
>> sending me a small paragraph [for the next CVS activity report] about
>> what you're doing in it and what is already possible and what
>> direction does it take ?
> 
>Yeah, there's no secret about what I'm doing with it, but just to clarify:
>
>netpgp is a high-level layer which sits on top of a heavily-modified
>openpgpsdk, and provides a library interface defined in
>/usr/include/netpgp.h - the main functions are:
>
>int netpgp_encrypt_file(netpgp_t *, char *, char *, char *, int);
>int netpgp_decrypt_file(netpgp_t *, char *, char *, int);
>int netpgp_sign_file(netpgp_t *, char *, char *, char *, int, int, int);
>int netpgp_verify_file(netpgp_t *, char *, const char *, int);

Shouldn't most of those char *'s be const char *, and in the code
the result of the __ops_functions should be checked, and appropriate
errnos set?

christos