Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Sat, May 16, 2009 at 10:05:36PM +0300, Alan Barrett wrote:
> On Sat, 16 May 2009, Andrew Doran wrote:
> > Thanks! How about this to avoid potential sign compare issues? I forgot
> > to e-mail you about it earlier.
> > 
> > @@ -252,8 +252,8 @@ typedef struct vnode vnode_t;
> >  /*
> >   * v_usecount; see the comment in vfs_subr.c
> >   */
> > -#define        VC_XLOCK        0x80000000
> > -#define        VC_MASK         0x7fffffff
> > +#define        VC_XLOCK        0x40000000
> > +#define        VC_MASK         (0xffffffff & ~VC_XLOCK)
> 
> It may be easier and safer to use 0x7fffffffUL.

Or __BIT()/__BITS() et cetera.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933