Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/dec



On Tue, May 12, 2009 at 04:24:07PM +0100, Robert Swindells wrote:
> 
> Valeriy E. Ushakov wrote:
> >On Tue, May 12, 2009 at 14:18:16 +0000, Christoph Egger wrote:
> 
> >> struct device * -> device_t, no functional changes intended.
> 
> >Why don't you cmp(1) the objects before and after to verify that?
> >"Same object code generated" is, unlike intentions, something that can
> >be verified.
> 
> A fair number won't be the same, I would guess half our SCSI drivers
> are currently broken.
> 
> Do a search in sys/dev/ic for 'adapt_dev', any driver that casts this
> to a softc instead of calling device_private() will crash.

As much as I dislike the way cegger does those changes, that's simply
not true.

-- 
Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.

Attachment: pgpt2hu5xjmbm.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index