Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/newfs_msdos



On Sun, Mar 29, 2009 at 10:47:58AM +0900, Izumi Tsutsui wrote:
 > > > > Add a cast to intmax_t and use %jd to print an off_t.
 > > > > Fixes at least the alpha and amd64 builds.
 > > > 
 > > > Why not PRId64?
 > > 
 > > It is future-safe. E.g. consider when in a few years we have to switch
 > > to 128bit off_t.
 > 
 > Hmm, if you seriously think about it, maybe PRIfoo for off_t is better.
 > 
 > Anyway, most our sources use PRId64 for off_t and time_t, though.

Even "long long" is better than that...

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index