Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/sbus



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Mar 27, 2009, at 9:07 AM, Izumi Tsutsui wrote:

ad%NetBSD.org@localhost wrote:

On Fri, Mar 27, 2009 at 12:25:41PM +0000, Izumi Tsutsui wrote:

Log Message:
Use bus_space(9) to access registers. SETREG() macro using bogus casts against packed structures doesn't work on gcc4. (no character on screen)
See also:
http://mail-index.NetBSD.org/port-sparc/2003/11/11/0002.html

It has been a long time, but from what I remember SETREG() was an invention of mine to work around either a compiler or code bug. Maybe bus_space does
the same.

I'm not sure if it's a compiler bug or not, but SETREG() doesn't work
on gcc4 while it's confirmed working on gcc3.
(as the noted in the above mail, it looks generating byte access code)

Removing __packed might also help, but bus_space(9) just works
and it's a right way to go, I think.

I strongly agree - I've been trying to get our zx driver to work for a while but got sidetracked by other stuff ( mostly sgimips-related ) - thanks for doing this. Writing an accelerated Xorg driver is next on my todo list ( after adding wscons support to zx )

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBSc03pspnzkX8Yg2nAQKKxQf/YUc7aXT66Jd1Vfe4l3eli7+j3IM1DDmY
qPmTLfEMNXfEsSnNAG3P3pWGSLPtRuq/miQDNe8VRhT9SEuiULTt30VX/BzNEg73
PxrQ1gd+59UzeETijZd+dK5ggvGvXuHoSqOB65J6f/eqxvOcZwL26FdrIDQ0OPqg
eOj7AzgyJZ4Z9NmqTDit8PsgTLxNoG1BQbuhqDynw8e4y0IKYZ52yoNRuLDwoUzl
Y7xURm+BXLhQuRTrjWs8UFw6Y+dIikLihOSAh0f0T3qXQcnrXc1fNGh+eHJOzEmG
OWsYS6Dx3j1QB+BDEixzg5/2yFoD8YZhgbqy5lpP7scLZjhzahWUQg==
=xXJG
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index